Skip to content

remove cliclack prompt #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsibbison-square merged 1 commit into from
Dec 17, 2024
Merged

remove cliclack prompt #484

jsibbison-square merged 1 commit into from
Dec 17, 2024

Conversation

@jsibbison-square
Copy link
Contributor

@jsibbison-square jsibbison-square commented Dec 17, 2024

Everyone is using the rustyline version for quite awhile and it has not had negative press compared to cliclack version. Therefore this PR removes the cliclack version, less maintenence.

baxen
baxen approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@baxen baxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsibbison-square jsibbison-square merged commit ab7ea6c into v1.0 Dec 17, 2024
3 checks passed
jsibbison-square added a commit that referenced this pull request Dec 17, 2024
@jsibbison-square
Merge branch 'v1.0' into jsibbison-20241217-command-history-resumed
a232795 
* v1.0:
  Newline in cli (#485)
  remove cliclack prompt (#484)
  feat:model-specific-configuration (#466)
lifeizhou-ap added a commit that referenced this pull request Dec 17, 2024
@lifeizhou-ap
Merge branch 'v1.0' into lifei/google-provider
534b64b 
* v1.0:
  Restore command history when resuming session (#483)
  Newline in cli (#485)
  remove cliclack prompt (#484)
  feat:model-specific-configuration (#466)
  Adds session cost to goose.log (#474)
michaelneale added a commit that referenced this pull request Dec 18, 2024
@michaelneale
Merge branch 'v1.0' into micn/electron-error-logging
f5abf4e 
* v1.0:
  feat: add google provider (#489)
  feat: flappy goose easter egg (#479)
  Restore command history when resuming session (#483)
  Newline in cli (#485)
  remove cliclack prompt (#484)
  feat:model-specific-configuration (#466)
@yingjiehe-xyz yingjiehe-xyz deleted the jsibbison-20241217-remove-cliclack branch February 5, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baxen baxen baxen approved these changes

@zakiali zakiali Awaiting requested review from zakiali

@lifeizhou-ap lifeizhou-ap Awaiting requested review from lifeizhou-ap

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsibbison-square @baxen